Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slice::reverse const #100663

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Make slice::reverse const #100663

merged 2 commits into from
Aug 21, 2022

Conversation

clarfonthey
Copy link
Contributor

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2022
@scottmcm
Copy link
Member

I'm a bit sad that we're forced to not use for/debug_assert_eq for this stuff, but the change seems fine.

Please open a tracking issue for it and add the issue number.

r? @scottmcm
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 19, 2022
@clarfonthey clarfonthey mentioned this pull request Aug 20, 2022
Closed
3 tasks
@clarfonthey
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2022
@scottmcm
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2022

📌 Commit ae2b1db has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#100663 - clarfonthey:const-reverse, r=scottmcm
51ea131 
Make slice::reverse const

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#100663 - clarfonthey:const-reverse, r=scottmcm
e432add 
Make slice::reverse const

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#100663 - clarfonthey:const-reverse, r=scottmcm
532db8f 
Make slice::reverse const

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#100663 - clarfonthey:const-reverse, r=scottmcm
6cc9dba 
Make slice::reverse const

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#100663 - clarfonthey:const-reverse, r=scottmcm
84dec7b 
Make slice::reverse const

I remember this not being doable for some reason before, but decided to try it again and everything worked out in the tests.
This was referenced Aug 21, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2022
@bors
Auto merge of rust-lang#100847 - matthiaskrgr:rollup-0ga531s, r=matth…
c0941df 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#100556 (Clamp Function for f32 and f64)
 - rust-lang#100663 (Make slice::reverse const)
 - rust-lang#100697 ( Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing`)
 - rust-lang#100760 (update test for LLVM change)
 - rust-lang#100761 (some general mir typeck cleanup)
 - rust-lang#100775 (rustdoc: Merge source code pages HTML elements together v2)
 - rust-lang#100813 (Add `/build-rust-analyzer/` to .gitignore)
 - rust-lang#100821 (Make some docs nicer wrt pointer offsets)
 - rust-lang#100822 (Replace most uses of `pointer::offset` with `add` and `sub`)
 - rust-lang#100839 (Make doc for stdin field of process consistent)
 - rust-lang#100842 (Add diagnostics lints to `rustc_transmute` module (zero diags))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1cdcf50 into rust-lang:master Aug 21, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 21, 2022
@clarfonthey clarfonthey deleted the const-reverse branch September 26, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
6 participants
@clarfonthey @rustbot @rust-highfive @scottmcm @bors @joshtriplett